SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

[WIP] Isothermal streamwise periodicity

Open NAnand-TUD opened this issue 2 years ago • 4 comments

Proposed Changes

Implementation of Streamwise periodic Iso-thermal BCs

Related Work

This is an add-on to the already existing Streamwise periodic flow solver. As a result, there are new source terms which are accounted for in the solution.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X ] I am submitting my contribution to the develop branch.
  • [ ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [ ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [ ] I have added a test case that demonstrates my contribution, if necessary.
  • [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

NAnand-TUD avatar Oct 27 '22 06:10 NAnand-TUD

Hi Nitish, can you remove the codi and opdi changes from the PR? This happens when your local codi/opdi is not up to date, so you should update these submodules.

bigfooted avatar Oct 27 '22 12:10 bigfooted

@bigfooted, Thanks for your comment. I tried but it was not reflected. I see that during the merge with develop the submodule commit keys got updated. Any clues how I can do this ?

NAnand-TUD avatar Oct 27 '22 14:10 NAnand-TUD

All tests are now passing, except CodeFactor. But I guess that was there even before I implemented anything. @bigfooted : Thanks for your commit.

NAnand-TUD avatar Oct 28 '22 19:10 NAnand-TUD

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

stale[bot] avatar May 21 '23 21:05 stale[bot]