SU2
SU2 copied to clipboard
su2code
[WIP] Composition-dependent heat capacities and mass diffusivity models for incompresible flows
Proposed Changes
Give a brief overview of your contribution here in a few sentences. Part 3/3 of fluid mixing model. In this part, Heat capacities and mass diffusivity based on species mass fractions have been added.
I am still working in checking the Non-dimensional case, I expect to complete it during this week.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any. It is the continuation of the previous pull request of mixing density #1620 and #1690.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
- [X] I am submitting my contribution to the develop branch.
- [X] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- [X] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- [X] I have added a test case that demonstrates my contribution, if necessary.
- [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
The naming "passive scalar' is inappropriate now. Maybe change this to 'species transport' everywhere. Looks like you can safely do a 'search and replace all' on "passive scalar" and "PASSIVE_SCALAR"
@Cristopher-Morales any things left for this PR? If PASSIVE_SCALAR is changed to SPECIES_TRANSPORT, and if you have confirmed that the nondimensionalization works correctly, then from my side it will be good to go. You can put a tutorial and regression test for the adjoint optimization in the next PR.
Btw, once you think a PR is ready for another review round, leave a message or remove [WIP] from the title.
I have added a pull request for the Tutorials in order to change PASSIVE_SCALAR to SPECIES_TRANSPORT #27. Please let me know if it is ok to do it.
Sure, is there anything on the website tutorials that needs to be updated?
Sure, is there anything on the website tutorials that needs to be updated? Hi, yes in the tutorial created by Tobias the option PASSIVE_SCALAR must be changed to SPECIES_TRANSPORT. Should I do a pull request for modifying it?