SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

[WIP] Radiative equilibrium wall bounday condition

Open jtneedels opened this issue 2 years ago • 2 comments

Proposed Changes

*This PR adds the capability of a radiative equilibrium wall boundary condition to the standard air and NEMO solvers.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [ x] I am submitting my contribution to the develop branch.
  • [ x] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • [ x] My contribution is commented and consistent with SU2 style.
  • [ ] I have added a test case that demonstrates my contribution, if necessary.
  • [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

jtneedels avatar Jul 09 '22 01:07 jtneedels

This looks pretty good! I think you should add a regression.

Should an incompressible version be added as well?

WallyMaier avatar Jul 09 '22 04:07 WallyMaier

This looks pretty good! I think you should add a regression. Thanks! Yeah good point, I'll work on making one.

Should an incompressible version be added as well? Mmmm, that's a good question. I think physically for aerodynamic heating loads to be sufficiently high, you'd need to have a high enough Ma to ned the compressible solver. But maybe there are cases in the incompressible solver where you're dealing with high temperature flows and want to model the wall radiation out? Maybe this is already implemented in a more complex way?

jtneedels avatar Jul 09 '22 11:07 jtneedels

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

stale[bot] avatar Oct 30 '22 04:10 stale[bot]

Trying to unstale this.

WallyMaier avatar Oct 31 '22 13:10 WallyMaier