[WIP] Supersonic inlet profile

[eskimmel]

Proposed Changes

Give a brief overview of your contribution here in a few sentences. This is a draft pull request for the implementation of a supersonic inlet profile feature. So far, the only changes made have been in CEulerSolver.cpp, where the uniform temperature, pressure, and velocity at the inlet for a supersonic inlet BC have been replaced with vertex values (please verify I did this correctly).

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any. I have been in communication with @bigfooted regarding the first steps for this implementation. I created a feature request for this on 5/25/2022.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

• [X] I am submitting my contribution to the develop branch.
• [ ] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
• [ ] My contribution is commented and consistent with SU2 style.
• [ ] I have added a test case that demonstrates my contribution, if necessary.
• [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

[eskimmel]

I just committed a second round of changes that I would appreciate some feedback on. Compilation is successful with these changes, however, upon testing, I receive the following message:

Error in "void CConfig::SetConfig_Parsing(std::istream&)":

Line 271 SPECIFIED_SUPERSONIC_INLET_PROFILE: invalid option name. Check current SU2 options in config_template.cfg. Did you mean SPECIFIED_INLET_PROFILE? Line 274 SUPERSONIC_INLET_FILENAME: invalid option name. Check current SU2 options in config_template.cfg. Did you mean INLET_FILENAME?

I had already adjusted CConfig.cpp to include supersonic inlet profile inputs, but apparently I am not implementing everything I need to. I'm unsure where else I would need to make changes. Any suggestions?

[bigfooted]

Hi! For some reason the files that you edited are not in the directories that they belong in, but are residing in the main SU2 directory. You have to move each of the files to the correct directory.

[eskimmel]

Whoops, thanks for letting me know! I'll fix that shortly.

[bigfooted]

OK, great. In the mean time, some changes were made to CEulerSolver.cpp by @pcarruscag , which is why it now says that there is a merge conflict here. You'll have to put these changes into your CEulerSolver.cpp to get rid of this conflict.

[eskimmel]

Upon implementing these changes, the compilation of the code failed due to multiple variables receiving conflicting declarations. After using just the variables @pcarruscag made and re-compiling, I receive multiple errors regarding the assignment of read-only variables, so I had to remove the "const" before a few lines to allow for compilation. Is this alright?

Also, any ideas about why SPECIFIED_SUPERSONIC_INLET_PROFILE is not being accepted as an option even though it's defined in CConfig.cpp?

[pcarruscag]

Why did you introduce supersonic-specific options? The inlet file allows specifying profiles for all markers, and a marker will not have 2 boundary conditions. From what I saw we just need to interpret the values in a different way.

[eskimmel]

I introduced supersonic specific options because, from my understanding, anything written in INLET_FILENAME in the .cfg file will be treated as a subsonic inlet, even if the marker tag is assigned to a supersonic inlet (including both profiles in the same inlet file results in immediate divergence). I wanted the static temperature, static pressure, and velocity vector to be read into SU2 for the supersonic profile and the total temperature, total pressure, and unit flow vector to be read for the subsonic profile. I figured that placing these different values in different files would be the easiest way to circumvent the issue stated above.

[pcarruscag]

I see, that should not be necessary because internally we can check that the marker is supersonic instead of subsonic and give the values a different interpretation. The incompressible solver does this when the inlet type is changed from total conditions to velocity inlet.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.