[WIP] Fix symmetry plane issues in SU2, change SU2-NEMO sym plane to match flow solver

[jtneedels]

Proposed Changes

This PR will help address issues seen in SU2 when symmetry planes are applied. These include pressure oscillations at sym plane & solid wall interfaces (i.e. blunt bodies). It will also change the implementation of the sym plane in SU2-NEMO to that used by the rest of the code, the template function in CFVMFlowSolverBase.inl.

Related Work

This PR will largely utilize the work done in #1168 by Fabio Morgado. It is in addition to #657. It will address several open issues #1625 and #1125.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

• [x] I am submitting my contribution to the develop branch.
• [x] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
• [x] My contribution is commented and consistent with SU2 style.
• [x] I have added a test case that demonstrates my contribution, if necessary.
• [x] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

[bigfooted]

hi guys, what's the status of this WIP? By the way, does this also show changes (improvements I hope) in convergence, or is that not affected by the change

[jtneedels]

Hi @bigfooted, I'm a bit perplexed because even with using the same sym plane BC in CFVMFlowSolverBase.inl as the standard air solver, the NEMO solver continues to have issues (pressure defects at stagnation point on sym boundary wall). The last working push in Fabio's original PR seem to fix these problems, but they involve some pretty significant changes to the code (complete change of BC, change of order of applications of BCs in CIntegration, etc.). I'm a bit stuck since I'm not sure why all these changes are necessary to get good results for NEMO, when the current implementation seems to work in CFVMFlowSolverBase.inl for the standard air solver. I was hoping to chat about this at the next developer meeting.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.