SU2 icon indicating copy to clipboard operation
SU2 copied to clipboard

Addition of catalytic isothermal wall boundary conditions in SU2-NEMO

Open jtneedels opened this issue 3 years ago • 2 comments

Proposed Changes

Addition and cleanup of isothermal catalytic wall boundary, integration with rest of code. Code optimization of catalytic wall routines, removal of array allocations.

Submitting this draft PR primarily to get comments on approach, style, not looking to PR into develop quite yet.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [x] I am submitting my contribution to the develop branch.
  • [x] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • [x] My contribution is commented and consistent with SU2 style.
  • [ ] I have added a test case that demonstrates my contribution, if necessary.
  • [ ] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

jtneedels avatar Nov 02 '21 05:11 jtneedels

I just updated to develop. Trying to "unstale" this.

WallyMaier avatar Mar 09 '22 06:03 WallyMaier

Im second guessing on whether we want hide the partially catalytic in fluid model as such i tried to condense the nasty if statement

WallyMaier avatar May 31 '22 06:05 WallyMaier