fix: ensure devserver client options are configurable

Open dannobytes opened this issue 3 years ago • 2 comments

trafficstars

When a custom webpackConfig.devServer.client option is set, they are currently being overridden by the baseConfig.client field.

Ensure that field is extendible by consumers while also ensuring the base config values stay fixed.

https://github.com/styleguidist/react-styleguidist/issues/2033

Sep 16 '22 23:09 dannobytes

@sapegin FYI, this fix is ready for review whenever you have a moment

Sep 19 '22 21:09 dannobytes

Codecov Report

Merging #2034 (f96c454) into master (80b5e84) will not change coverage. The diff coverage is 100.00%.

Impacted Files	Coverage Δ
src/scripts/create-server.ts	`92.30% <100.00%> (ø)`

Sep 20 '22 12:09 codecov[bot]

:tada: This PR is included in version 12.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Oct 06 '22 07:10 github-actions[bot]