WIP: Webpack 5 upgrade

[ThomasRoest]

This is a start for upgrading to webpack 5 and webpack-dev-server ^4. With these changes, the basic examples are working ( incl. hot module reloading ). But there are more todo's left

Todo

• [x] update dev-server config
• [x] make StyleguidistOptionsPlugin.ts work with webpack 5 and fix test
• [x] fix make-webpack-config.spec.ts tests
• [x] upgrade other webpack loader dependencies to latests versions (optional?)
• [x] fix type errors
• [x] fix deprecation warnings

This fixes some issues like #1932 This requires a new major release

[ThomasRoest]

@sapegin What is your vision concerning the future of this project? I'm willing to help out with some maintenance ( like this pull request ). Do you have time to review / accept these updates?

[ThomasRoest]

Hey, thanks for the pull request! I'm happy to give you more rights here if you have time and the desire to work on the project. Unfortunately, I don't have either right now.

https://blog.sapegin.me/all/going-offline/

sure! I'll mainly work on updating dependencies. There is one issue however that I might need help with, as it seems that the algolia search is no longer working...https://github.com/styleguidist/react-styleguidist/issues/1992

[sapegin]

I gave you write access to the repository ;-)

[codecov[bot]]

Codecov Report

Merging #1996 (cd02637) into master (4c55077) will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted Files	Coverage Δ
...ent/rsg-components/Arguments/ArgumentsRenderer.tsx	100.00% <ø> (ø)
.../client/rsg-components/Methods/MethodsRenderer.tsx	100.00% <ø> (ø)
src/client/rsg-components/Usage/Usage.tsx	100.00% <ø> (ø)
src/scripts/make-webpack-config.ts	100.00% <ø> (ø)
src/client/rsg-components/Editor/Editor.tsx	100.00% <100.00%> (ø)
...onents/Markdown/Details/DetailsSummaryRenderer.tsx	100.00% <100.00%> (ø)
src/client/rsg-components/Preview/Preview.tsx	100.00% <100.00%> (+2.56%)	:arrow_up:
...ent/rsg-components/TabButton/TabButtonRenderer.tsx	100.00% <100.00%> (ø)
...onents/TableOfContents/TableOfContentsRenderer.tsx	100.00% <100.00%> (ø)
src/client/utils/compileCode.ts	100.00% <100.00%> (ø)
... and 12 more

[ThomasRoest]

@sapegin We have been working on the upgrade to webpack 5 and the related dependencies. What would be the steps required to release this?

[sapegin]

Thanks! I can have a look quickly, if it's ready, and then we merge it, and pray that semantic-release still works.

https://react-styleguidist.js.org/docs/maintenance

[ThomasRoest]

@sapegin Did you have time to take a look? The only step that is failing right now is codecov/patch. I'm not really familiar with codecov so not sure yet how to fix this.. will look into it.

[sapegin]

There are still a few unresolved comments, anys and ases, otherwise it looks good.

[ThomasRoest]

@sapegin should be good now right?

[sapegin]

There are still open comments and a lot of new anys and ases.

[ThomasRoest]

sorry but I don't know which comments you are talking about, the ones from your review are resolved. Concerning the new any's and as assertions, again which ones?

[sapegin]

I see at least one suggestion above, for the any and as — there should be none of them added to the codebase.

This kind of code reviews take too much time from me, I'm tired of repeating everything 20 times, and I'm going to ignore any activity in this project in the future. Open source became too damaging to my mental health.

[ThomasRoest]

I see at least one suggestion above, for the any and as

I fixed those suggestions.

there should be none of them added to the codebase.

This is not realistic, there are always situations in which you need an escape hatch, and I can't replace all the existing any's and as assertions that where already in the codebase. Also I think all these outdated dependencies/lack of maintenance are a bigger problem for this project than a few any or 'as' assertions.

This kind of code reviews take too much time from me, I'm tired of repeating everything 20 times, and I'm going to ignore any activity in this project in the future. Open source became too damaging to my mental health.

I understand! But we've already put in alot of work for this pull request, so I would really like to complete this. Thank you!

[ThomasRoest]

@sapegin i fixed the remaining new 'any's that I've missed in this pull request. Others where already in the code.

[github-actions[bot]]

:tada: This PR is included in version 12.0.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: