styled-components icon indicating copy to clipboard operation
styled-components copied to clipboard

Allow Passing Shadow Root as Sheet Target

Open joealden opened this issue 1 year ago • 2 comments

In @types/styled-components, the target prop of StyleSheetManager allows passing a ShadowRoot (see here).

As I'm not familiar with this codebase, I started from the change to IStyleSheetManager, then fixed any type errors that surfaced. @quantizor please let me know if you see any problems with what I've done here, or if you know of a reason why the ShadowRoot option wasn't carried over into v6!

joealden avatar May 11 '24 14:05 joealden

@quantizor sounds good to me! Do you think it should live in /src/types.ts or /src/sheet/types.ts?

joealden avatar May 11 '24 14:05 joealden

@quantizor sounds good to me! Do you think it should live in /src/types.ts or /src/sheet/types.ts?

src/types is good :)

quantizor avatar May 11 '24 14:05 quantizor