atom-terminal-panel icon indicating copy to clipboard operation
atom-terminal-panel copied to clipboard

path.extname is deprecated.

Open sonuterrific opened this issue 7 years ago • 50 comments

Argument to path.extname must be a string

path.extname (/usr/share/atom/resources/app.asar/src/electron-shims.js:20:10)
ATPOutputView.getCwd (/home/sudhanshu/.atom/packages/atom-terminal-panel/lib/atp-view.coffee:1874:17)
BuiltinVariables.parseFull (/home/sudhanshu/.atom/packages/atom-terminal-panel/lib/atp-builtins-variables.coffee:188:77)
BuiltinVariables.parseHtml (/home/sudhanshu/.atom/packages/atom-terminal-panel/lib/atp-builtins-variables.coffee:111:16)
ATPOutputView.parseTemplate (/home/sudhanshu/.atom/packages/atom-terminal-panel/lib/atp-view.coffee:664:36)
ATPPanel.updateStatusBar (/home/sudhanshu/.atom/packages/atom-terminal-panel/lib/atp-panel.coffee:190:50)

sonuterrific avatar Dec 08 '16 19:12 sonuterrific

atom-terminal-panel(1 deprecation) i have the same deprecation

beamaster avatar Jan 18 '17 01:01 beamaster

same problem

DeRaNGeR avatar Jan 19 '17 10:01 DeRaNGeR

same problem

miladyalda avatar Jan 22 '17 14:01 miladyalda

same here

yulis avatar Jan 25 '17 10:01 yulis

+1

flatwound avatar Jan 27 '17 08:01 flatwound

same

dichioniccolo avatar Jan 28 '17 11:01 dichioniccolo

same here.

luolisave avatar Feb 01 '17 18:02 luolisave

I have the same problem here... 😢

AuggieMBP avatar Feb 02 '17 16:02 AuggieMBP

So I was able to temporarily fix this issue... it could also just be a workaround so please follow this at your own risk. It did however remove the "deprecation" message from atom for me.

On the deprecated call, click on the second path: ATPOutputView.getCwd (/home/sudhanshu/.atom/packages/atom-terminal-panel/lib/atp-view.coffee:1874:17)

In the atp-view.coffee file, for the getCwd method, you will want to make the following edits to the extFile and projectDir variables: extFile = extname atom.project.getPaths()[0] if typeof atom.project.getPaths()[0] is 'string' projectDir = dirname atom.project.getPaths()[0] if typeof atom.project.getPaths()[0] is 'string'

these are lines 1318 and 1331 respectively.

getCwd` should look like this:
  `getCwd: ->
    if not atom.project?
      return null
    extFile = extname atom.project.getPaths()[0] if typeof atom.project.getPaths()[0] is 'string'

    if extFile == ""
      if atom.project.path
        projectDir = atom.project.path
      else
        if process.env.HOME
          projectDir = process.env.HOME
        else if process.env.USERPROFILE
          projectDir = process.env.USERPROFILE
        else
          projectDir = '/'
    else
      projectDir = dirname atom.project.getPaths()[0] if typeof atom.project.getPaths()[0] is 'string'

    cwd = @cwd or projectDir or @userHome
    return @correctFilePath cwd

I hope this helps. I was glad I no longer saw the deprecation message 😆

AuggieMBP avatar Feb 02 '17 17:02 AuggieMBP

Created a Pull Request for this (#118) based on @AuggieMBP's comment

ShiningTrapez avatar Feb 10 '17 10:02 ShiningTrapez

Same problem... When an updated to the package will be released? I like much this package but don't like to have deprecation alert in my atom :(

arsari avatar Feb 21 '17 13:02 arsari

same problem

sherlockkk avatar Feb 24 '17 05:02 sherlockkk

same issue

phinias12 avatar Mar 09 '17 02:03 phinias12

same issue

prakasa1904 avatar Mar 11 '17 05:03 prakasa1904

same issue

Quwater avatar Mar 16 '17 08:03 Quwater

same issue

karayel avatar Mar 29 '17 14:03 karayel

same issue

jtshaver avatar Apr 05 '17 03:04 jtshaver

same issue

ysicing avatar Apr 06 '17 09:04 ysicing

same issue

pakdel avatar Apr 06 '17 13:04 pakdel

same issue

fbrillon avatar Apr 06 '17 20:04 fbrillon

same issue

radwasherif avatar Apr 12 '17 02:04 radwasherif

Solution from @AuggieMBP solve problem

tonskey avatar Apr 12 '17 17:04 tonskey

same issue

yanxiaobo avatar Apr 16 '17 02:04 yanxiaobo

I have an issue the charset codification of the console, look this text: "El n�mero de serie del volumen es: ECA4-13CE" How can i upgrade this charset tu UTF-8?

Thanks!

Encr1pt3d avatar Apr 19 '17 10:04 Encr1pt3d

Yup, same here....

tmcarr avatar Apr 27 '17 18:04 tmcarr

FYI here is a Deprecated calls I am getting

Argument to path.extname must be a string Report Issue path.extname - /Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:20:10 ATPOutputView.getCwd - /Users/stigadmin/.atom/packages/atom-terminal-panel/lib/atp-view.coffee:1874:17 BuiltinVariables.parseFull - /Users/stigadmin/.atom/packages/atom-terminal-panel/lib/atp-builtins-variables.coffee:188:77 BuiltinVariables.parseHtml - /Users/stigadmin/.atom/packages/atom-terminal-panel/lib/atp-builtins-variables.coffee:111:16 ATPOutputView.parseTemplate - /Users/stigadmin/.atom/packages/atom-terminal-panel/lib/atp-view.coffee:664:36 ATPPanel.updateStatusBar - /Users/stigadmin/.atom/packages/atom-terminal-panel/lib/atp-panel.coffee:190:50

nixbytes avatar May 05 '17 15:05 nixbytes

+1

ghost avatar May 10 '17 16:05 ghost

+1

not-me-svg avatar May 11 '17 07:05 not-me-svg

+1

eafomi4ev avatar May 11 '17 08:05 eafomi4ev

+1

alugarius avatar May 20 '17 18:05 alugarius

same problem

FelixTang-only avatar May 24 '17 07:05 FelixTang-only

Up

JanineAmelie avatar May 25 '17 17:05 JanineAmelie

+1

svedova avatar May 26 '17 11:05 svedova

+1

leoek avatar May 28 '17 17:05 leoek

+1

ianlater avatar Jun 05 '17 18:06 ianlater

I did as what @AuggieMBP had said.And the problem was solved.

MarioJY avatar Jun 06 '17 06:06 MarioJY

+1

soumendra avatar Jun 07 '17 05:06 soumendra

+1

walok avatar Jun 20 '17 17:06 walok

+1

jnchen avatar Jun 22 '17 05:06 jnchen

+1

Fretice avatar Jun 26 '17 07:06 Fretice

I think this is dead

alugarius avatar Jun 26 '17 10:06 alugarius

+1

fppgodinho avatar Aug 10 '17 10:08 fppgodinho

@Encr1pt3d : please find a patch for charset issue https://github.com/styczynski/atom-terminal-panel/pull/175

VadimDor avatar Aug 18 '17 14:08 VadimDor

@AuggieMBP Thanks man

codeymac888 avatar Aug 22 '17 20:08 codeymac888

+1

ahalcyon avatar Aug 27 '17 09:08 ahalcyon

o.O3 ---> any update ?

prakasa1904 avatar Aug 28 '17 03:08 prakasa1904

+1

simonzsolt avatar Feb 05 '18 12:02 simonzsolt

I have the same issue

ghost avatar Jun 27 '18 16:06 ghost

Still not fixed?

Xinatorus avatar Jan 02 '19 11:01 Xinatorus

still not fixed

ishuacharis avatar Dec 14 '19 21:12 ishuacharis