Steffen Vogel

Results 326 comments of Steffen Vogel

Can we separate the retry logic into a separate PR? I think its unrelated to the IPv6 support.. Also https://github.com/pion/turn/pull/265 might get obsolete if https://github.com/pion/turn/pull/276 gets merged.

@davidzhao Hi David, do you have updates on your testing? I think I've encountered the same issue.

I agree with @jerry-tao here. However, does not this also apply to TCP? I find the naming of `InboundMTU` misleading. I think we need to in fact refer to it...

@jackyshaw2017 Can you provide some more context or a minimal example which demonstrates the issue? Did you implement a TURN server or client? Which implementation has been used on the...

Thanks @rg0now for addressing my comments. To get this merged, we need to rebase it on the latest master and fix the commit messages as they cause the CI to...

Thanks @rg0now, The CI is running again. But the commit messages are still not conformant to the Pion CI checks: ``` The preceding commit message is invalid it failed 'Separate...

I think the Codecov error is only transient. > the corresponding commit message is only a single line (Fix linter warnings). Any ideas? I agree. I think the check is...

There is also another check which fails `golangci-lint`: > Error: cognitive complexity 33 of func `NewServer` is high (> 30) (gocognit)

I agree with both of your comments. However, lets try to get the `PermissionHandler` merged first. Could you add `//nolint:gocognit` comment above the `NewServer()` function to silence the linter? Also...