wp-event-calendar icon indicating copy to clipboard operation
wp-event-calendar copied to clipboard

Non publicly queryable

Open joelworsham opened this issue 9 years ago • 5 comments

Love the plugin. One major hurdle though is you've disabled public querying with no way to filter it. I'm currently having to manually change that line of code to use it in my theme. I understand the plugin itself has no front-end functionality, but why prevent others from doing so?

I'd love to see this patched or something soon so I can update the plugin on the next release ;)

joelworsham avatar Dec 01 '15 21:12 joelworsham

You can modify the post-type global directly if you wanted to enable this functionality.

The reason it's not enabled is because events would otherwise get front-end URLs that the plugin isn't setup to directly support yet. In a perfect world, this plugin would come equipped with template parts to provide basic support for public events.

It'll happen; it's just not a huge priority quite yet.

JJJ avatar Dec 30 '15 23:12 JJJ

So... I still didn't get this into 0.3.0.

I am in the process of creating a piggy-back plugin to address this, which adds support for single event pages and a calendar archive page template. If that goes well, I'll either merge that into this plugin, or keep it separate and close this.

JJJ avatar Mar 30 '16 19:03 JJJ

That'd be sweet! I'll keep my eyes open for that.

Is there any reason you prefer to have developers filter the post-type global rather than passing all your args through filters at the point of registering?

joelworsham avatar Mar 30 '16 20:03 joelworsham

Is there any reason you prefer to have developers filter the post-type global rather than passing all your args through filters at the point of registering?

This is a good question. The short answer is that I knew the register_post_type_args filter was coming in WordPress 4.4. The long answer is that there is a part of me that wants to separate the Calendar from the Events post type, and have them be two separate plugins, so I'm reluctant to introduce custom filters that I way want to rename eventually.

JJJ avatar May 03 '16 04:05 JJJ

Gotcha. Fair enough. Thanks for the info.

joelworsham avatar May 03 '16 12:05 joelworsham