ludicrousdb icon indicating copy to clipboard operation
ludicrousdb copied to clipboard

Tag 4.2 has a ludicrousdb.php file that says "Version: 5.0.0"

Open cordulack opened this issue 4 years ago • 5 comments

We are looking to upgrade to the latest version of ludicrousdb and I was hoping someone could clarify something.

When you look at the code in the 4.2 tag, ludicrousdb.php says it is version 5.0. Should the tag and the version in this file match?

https://github.com/stuttter/ludicrousdb/blob/4.2.0/ludicrousdb.php#L11

/**
 * Plugin Name: LudicrousDB
 * Plugin URI:  https://github.com/stuttter/ludicrousdb
 * Author:      JJJ & Friends
 * Author URI:  https://github.com/stuttter/ludicrousdb/graphs/contributors
 * License:     GPL v2 or later
 * License URI: https://www.gnu.org/licenses/gpl-2.0.html
 * Text Domain: ludicrousdb
 * Version:     5.0.0
 * Description: An advanced database interface for WordPress that supports replication, fail-over, load balancing, and partitioning
 */

Thanks!

cordulack avatar Feb 04 '21 19:02 cordulack

That's really annoying. I think this is because the 4.2 tag was being deleted by the mirror, and we had to force the tag, and it just got missed.

It's embarrassing, but won't break anything. When we release 5.1.0, it'll still be OK.

JJJ avatar Jul 14 '21 17:07 JJJ

@JJJ is it not also related to the emojified release name or the date on 4.2.0 GH release being newer than 5.0.0?

LudicrousDB releases page LudicrousDB GitHub sidebar

I think you can fix the emojis/force update the 5.0.0 tag/release date to have it shown as latest, without any ill effects (Packagist shows 5.0.0 as latest correctly already)

leonstafford avatar Aug 08 '21 02:08 leonstafford

If someone's trying to check what version is installed on a non-Composerified site, can compare the 5.0.0 and 4.2.0 tags here: https://github.com/stuttter/ludicrousdb/compare/5.0.0...4.2.0

and easy check is the ./ludicrousdb.php file, line 44, should have the // phpcs:ignore comment, as per current master branch: https://github.com/stuttter/ludicrousdb/blob/dc3167b9696e9adbb3834a39453c2cc5575c65c4/ludicrousdb.php#L44

leonstafford avatar Aug 08 '21 02:08 leonstafford

So really 4.2.0 is newer in features over 5.0.0?

thefrosty avatar Nov 19 '21 00:11 thefrosty

So really 4.2.0 is newer in features over 5.0.0?

No. 5.0.0 is newer. 5.1.0 is latest.

The 4.2.0 tag was pushed in error by a mirror I'd setup and was half broken. 😔

JJJ avatar Nov 19 '21 15:11 JJJ

Closing this. Automatic mirroring is disabled.

JJJ avatar Apr 23 '24 17:04 JJJ