ruby-tapas-downloader icon indicating copy to clipboard operation
ruby-tapas-downloader copied to clipboard

Published 20 hours ago • verified publisher icon stupied4ever

What about making this more generic?

Open joakimk opened this issue 11 years ago • 5 comments
trafficstars

Just a thought...

I managed to use this to download elixir sips with some tiny modifications. There doesn't seem to be a "dpdcart downloader", but this could be that relatively easily.

joakimk avatar Jul 16 '14 18:07 joakimk

@joakimk that sounds like a good idea :smile:

Could you please share some toughts on how you carried the changes to download elixir sips? Or, better yet, work on a PR to get this done?

:heart:

leafac avatar Jul 17 '14 12:07 leafac

I guess it's mostly just renaming things to be more generic and making the urls configurable without having to change config/urls.yml within the gem.

joakimk avatar Jul 17 '14 20:07 joakimk

@joakimk sounds easy enough. And how do you think the user should choose which dpdcart product they want to download? A command line option?

leafac avatar Jul 18 '14 11:07 leafac

Probably its a good idea, @joakimk can you send a pull request? As its your idea, i think it's fair that you take the kudos.

stupied4ever avatar Jul 19 '14 17:07 stupied4ever

Also, I don't subscribe to any other dpdcart product, so I'm not in position to conduct this feature development :smile:

leafac avatar Jul 25 '14 17:07 leafac