git-hooks icon indicating copy to clipboard operation
git-hooks copied to clipboard

Install all command

Open jbodah opened this issue 9 years ago • 14 comments

Still needs automated tests. Tested manually

  • Add a support for git_hooks install to install every hook
  • Convert hook.sample into an ERB template and generate the correct template based on the hook

jbodah avatar May 22 '15 02:05 jbodah

Coverage Status

Coverage increased (+0.17%) to 99.19% when pulling cbb9b75cb765ae87a2bf82c9a373687c8543c1a2 on jbodah:install-all into 53247cfa8a8c40fd47ceacee4ac7ed57a674b3c2 on stupied4ever:master.

coveralls avatar May 22 '15 02:05 coveralls

Coverage Status

Coverage increased (+0.15%) to 99.18% when pulling 174372f078054ad1e3dbd516c2bea3a2d9031819 on jbodah:install-all into 53247cfa8a8c40fd47ceacee4ac7ed57a674b3c2 on stupied4ever:master.

coveralls avatar May 22 '15 02:05 coveralls

Wow, that is nice!!

I have some little advices, I will do them in the commits.

stupied4ever avatar May 22 '15 02:05 stupied4ever

Cool, sounds good

jbodah avatar May 22 '15 02:05 jbodah

On the installer, the ruby_path is nil by default, but in the template we set a new default (ruby_path || some default path). This default path should go to installer default para, doesn't?

stupied4ever avatar May 22 '15 02:05 stupied4ever

I see, yeah that makes sense

jbodah avatar May 22 '15 02:05 jbodah

That sounds promissor! The a lot.

stupied4ever avatar May 22 '15 02:05 stupied4ever

@stupied4ever please let me know which changes you'd like still. I've commented on the lines you've mentioned.

I still would like to write tests for this

jbodah avatar May 22 '15 13:05 jbodah

Probably the only thing you need to fix is the puts (as you created the log feature).

stupied4ever avatar May 22 '15 23:05 stupied4ever

Gotcha, I'll merge upstream when I get home

jbodah avatar May 22 '15 23:05 jbodah

other point I was thinking is that we got a Install All command, but by the moment we have only PreCommit hooks. We created A multi hook type but we did not completed other hooks Type. The user will never be able to install all, only install PreCommit.

I need to find somre time to complete that PR that still in WIP

stupied4ever avatar May 22 '15 23:05 stupied4ever

Coverage Status

Coverage increased (+0.15%) to 99.18% when pulling e9f6b41db46c6ae789c5f6460bc5c35beb45ad54 on jbodah:install-all into 85eb9c55e6ae4b43d99d92331d4b0723291d4b77 on stupied4ever:master.

coveralls avatar May 26 '15 21:05 coveralls

Coverage Status

Coverage increased (+0.15%) to 99.18% when pulling e9f6b41db46c6ae789c5f6460bc5c35beb45ad54 on jbodah:install-all into 85eb9c55e6ae4b43d99d92331d4b0723291d4b77 on stupied4ever:master.

coveralls avatar May 26 '15 21:05 coveralls

Coverage Status

Coverage increased (+0.15%) to 99.18% when pulling e9f6b41db46c6ae789c5f6460bc5c35beb45ad54 on jbodah:install-all into 85eb9c55e6ae4b43d99d92331d4b0723291d4b77 on stupied4ever:master.

coveralls avatar May 26 '15 22:05 coveralls