stump icon indicating copy to clipboard operation
stump copied to clipboard

:sparkles: Scanner ignore rules and :lipstick: library settings refactor

Open aaronleopold opened this issue 1 year ago • 2 comments

This PR has two distinct and large features:

  1. DB-level ignore rules to better control which files are scanned
  2. Redesign the library settings and library creation pages

I've overhauled the navigation for those two pages, I think it is a lot more organized but am open to feedback nonetheless. There are a few fixes in here, too, and odds and ends:

  • Add CI step for asserting the codegen is up-to-date
  • Fix the rimraf utility commands for quickly clearing the repo of node_modules
  • Fix the component which allows you to select tags for an entity, e.g. a library, and re-add it to forms where it was previously removed
  • Fix tag creation and linking/unlinking during library create/update
  • Add an initialize fn to the job manager
  • Add secret fun thing for certain milestones, e.g. creating a library
  • Add a ton of locale mappings to the library forms
    • Not 100% coverage yet, but I'll aim to get there before merging this in

.. And more, I'm sure I am forgetting something. There is still a good bit of work to go, and then review of what's changed, but I'm hoping to wrap this up either this weekend or the following one.

aaronleopold avatar Aug 28 '24 02:08 aaronleopold

This is looking pretty good so far!

In my testing I found a pretty gnarly regression in the scanner, unrelated to these changes though. I ran out of time to isolate/cherry-pick it to nightly today but I will aim to do it tomorrow. The commit with the tentative fix is: https://github.com/stumpapp/stump/pull/422/commits/61e7dbdd03b296bae40340a379c0b476a238c4fc

aaronleopold avatar Aug 29 '24 01:08 aaronleopold