Stu Hood

Results 228 comments of Stu Hood

Possibly related to #1422... will see if I can get a before/after repro.

Thanks for the report. I think that this will require a drop guard which is moved into the stream here: https://github.com/pantsbuild/pants/blob/cae2e9ae7540cd1932ebe24a23b74356532e15d2/src/rust/engine/process_execution/src/docker.rs#L495-L543 Because we use cached/long-lived containers, the drop guard will...

What about splitting and having two CIs: one that runs for pull requests, and another that just runs nightly to see whether pantsbuild/pants has changed in a backwards incompatible way?...

Broad set of reviewers here, both for feedback and as an FYI.

Thanks for the report. Do you have time submit a PR for it? On May 2, 2017 5:21 PM, "LathamKing" wrote: When used from sbt-assembly, an attempt to shade the...

@chrisjbremner : @jacobnlsn is taking a swing at this, but would welcome your insight. If you're interested, joining the #pex channel in [pantsbuild slack](https://www.pantsbuild.org/docs/community#slack) would be really helpful!

@sureshjoshi : One way to split this up might be for me to implement something that does steps 1 through 3 from the description, and then for you to do...

> We may want to bump the major version to 3.x when we get rid of the solver, as this will require substantial rewrites of external plugins. It shouldn't, assuming...

One other item here: `MultiGet` is still named `MultiGet`, but if we're going to rename it (I liked @benjyw's suggestion of `await concurrently(...)` [here](https://github.com/pantsbuild/pants/discussions/18905#discussioncomment-5810753)), we should likely do so before...

It looks we already use [`tokenize`](https://docs.python.org/3/library/tokenize.html) internally for the BUILD file rewriting tool. It seems to be possible to preserve most formatting (importantly: comments) with `tokenize`, so I think that...