chordly icon indicating copy to clipboard operation
chordly copied to clipboard

Make bin page searchable

Open stufro opened this issue 5 months ago • 4 comments

I'd like to be able to search list of chord sheets which have been deleted.

Requirements

  • [ ] The existing search_controller.js is used to implement the search functionality
    • You can see examples of how this is used on the chord sheet and set list show pages.
    • For example in the chords sheets _library.html.slim partial, the search controller is attached to a div and the input element is configured, then in _chord_sheet.html.slim partial on line 1 we define the target and line 9 define the search term.
  • [ ] A cypress test is added in spec/cypress/e2e/chord_sheets.cy.js
    • Run rake cy:open to run tests whilst developing
    • You can define a test with it.only("...") to make cypress just run that 1 test on reload
Image

stufro avatar Jul 21 '25 18:07 stufro

Hey

I saw this post on Reddit. I'd love to take this one

ivnhk avatar Jul 22 '25 09:07 ivnhk

It's yours! Check out CONTRIBUTING.md for how to get setup locally (hopefully it's still up to date, will be great if you can update it if you find it's not)

stufro avatar Jul 22 '25 09:07 stufro

@stufro sorry for bothering. I made it up and running on localhost:3000. Seems to operate okay.

Now, I lack a bit of info on how to login/get to search and how to actually test the thing at least manually. Can you help me out with that, please?

ivnhk avatar Aug 07 '25 15:08 ivnhk

Hey @ivnhk , if you have run rails db:seed it will create some sample users for you. There is an icon on the right-hand side of the navbar you can use to login as any user.

Then you can create some chord sheets, when you delete a chord sheet you should see a blue Bin button on the My Library page, that's where the deleted chord sheets and set lists are.

I'm away from home and don't have my laptop so I can't share screenshots, but let me know if anything doesn't make sense and I'll try my best to explain! Good luck 😊

stufro avatar Aug 07 '25 15:08 stufro