foo_midi icon indicating copy to clipboard operation
foo_midi copied to clipboard

Nuked SC-55 support?

Open TransBluelight opened this issue 1 year ago • 3 comments

Would it be possible to add Nuked SC-55 support? GitHub repo: https://github.com/nukeykt/Nuked-SC55/tree/master

TransBluelight avatar Sep 27 '24 18:09 TransBluelight

I'll have a look at it.

stuerp avatar Sep 28 '24 07:09 stuerp

I think we'll use this via CLAP plugin if foo_midi support CLAP, because johnnovak made CLAP plugin of this. https://github.com/johnnovak/Nuked-SC55-CLAP

basic2004 avatar Jan 28 '25 08:01 basic2004

The SC-55 code is part of the latest alpha build but the timing is still off. The SDL code uses a timer while foobar2000 is event driven.

I'll have a look later what CLAP support would mean for foo_midi. I never heard of it.

stuerp avatar Jan 28 '25 18:01 stuerp

Took a look at https://github.com/stuerp/foo_midi/releases/tag/v2.19.0.0-alpha3

stuerp avatar Jun 25 '25 20:06 stuerp

Took a look at https://github.com/stuerp/foo_midi/releases/tag/v2.19.0.0-alpha3

Thanks, I tested it, pitch is incorecct currently but I adjusted sample rate to 32768Hz forced then I heard pitch is almost correct.

Some files can't start or stuck, and starts memory leaking until kill foobar2000 from task manager... I attach these files here. sample-test.zip

This test sample contains these songs. DEMO0001.MID (SC-55 demo song) WORM.MID (SC-55 mk2 demo song)

basic2004 avatar Jun 26 '25 12:06 basic2004

It's still a rough, first version. The sample rate isn't even adjusted yet: it's hard-coded at 33103.0Hz. The startup of the player still needs to be optimized.

But if the plug-in hangs while rendering it takes foobar2000 with it because it's loaded in-process (which is what I think a DAW does to prevent latency). If the hang is reproducible, I can contact the plug-in author. He already responded to some of my questions.

stuerp avatar Jun 26 '25 16:06 stuerp

This test sample contains these songs. DEMO0001.MID (SC-55 demo song) WORM.MID (SC-55 mk2 demo song)

I think it's a bug in the CLAP plugin and reported it here.

stuerp avatar Jun 28 '25 11:06 stuerp

It was a bug in my code. Should be fixed in alpha5.

stuerp avatar Jul 02 '25 12:07 stuerp

Thanks for fixing! I tested and works well. But I had a new issue, foobar2000 is crashed when double clicked next or previous track, I tried to play another song when initializing before start a song, this issue appeared.

basic2004 avatar Jul 04 '25 12:07 basic2004

Does any of the paths of the MIDI files contain Unicode characters?

stuerp avatar Jul 04 '25 14:07 stuerp

No any unicode in my file paths when tested.

R:\MIDI\Sound Canvas Demos\SC-55 Demos\DEMO0001.MID R:\MIDI\Sound Canvas Demos\SC-55 Demos\DEMO0002.MID R:\MIDI\Sound Canvas Demos\SC-55 Demos\DEMO0003.MID ... R:\MIDI\Sound Canvas Demos\SC-55 MKII Demos\WORM.MID R:\MIDI\Sound Canvas Demos\SC-55 MKII Demos\YEBISU.MID

basic2004 avatar Jul 05 '25 11:07 basic2004

Hmm, I haven't had any crashes with ASCII paths. I'm preparing to release alpha6 and will retest to see if I can reproduce it.

stuerp avatar Jul 05 '25 20:07 stuerp

No crashes in https://github.com/stuerp/foo_midi/releases/tag/v2.19.0.0-alpha6 (or the previous version).

Can you confirm?

stuerp avatar Jul 05 '25 21:07 stuerp

Sorry for too late response. I thought this crash issue solved since v.3.1.0.0-alpha6. Many thanks! :)

basic2004 avatar Aug 05 '25 12:08 basic2004