Victron CAN-bus voltage alarm swapped

[bertvaneyken]

trafficstars

I think the voltage alarm is swapped in the Victron CAN bus implementation, can someone else have also a look at this code?

Line 296

//(bit 2+3) Battery low voltage alarm
data.byte0 |= ((rules.rule_outcome[Rule::BankOverVoltage] | rules.rule_outcome[Rule::CurrentMonitorOverVoltage]) ? BIT23_ALARM : BIT23_OK);
//(bit 4+5) Battery high voltage alarm
data.byte0 |= ((rules.rule_outcome[Rule::BankUnderVoltage] | rules.rule_outcome[Rule::CurrentMonitorUnderVoltage]) ? BIT45_ALARM : BIT45_OK);

I couldn't explain the bank undervoltage alerts on my GX device when I was at the top end balancing as it overshot the values. This might be the source of this error.

Maybe an improvement to add: Add a option to set a specific charge current when cells start to balance, the setting available now to stop charging momentary when a cell starts dumping current. This slows the process down a bit.

[stuartpittaway]

What version of Victron firmware are you running? People have seen this alert change behaviour between Victron firmware releases.

[bertvaneyken]

Victron GX = v2.94

DIYBMS = Version: [5b7135f8127c6fd9d5d18525f7d5de72a32b4232]

Compiled: 2023-04-17T08:23:56.977Z

[bertvaneyken]

@stuartpittaway did you obtain documentation on the DVCC/Victron CAN-bus implementation or was it reverse engineered?

[stuartpittaway]

@stuartpittaway did you obtain documentation on the DVCC/Victron CAN-bus implementation or was it reverse engineered?

Victron provided some documentation for me, although there were some inaccuracies in it.

[bertvaneyken]

I didn't notice the controller unexpectedly rebooted, when this happend the Victron Multiplus 2 gives a "low battery voltage" alarm and shuts the inverter off.

I'm not sure but if I change parameters/rules the software isn't happy after a while and reboots.

[stuartpittaway]

Ok - in which case I would need to get a copy of the log files from the USB port on the ESP32 when this scenario occurs - unfortunately this would mean leaving a computer running to capture this output.

[virtuvas]

@bertvaneyken check what I and others posted in #220:

https://github.com/stuartpittaway/diyBMSv4ESP32/issues/220#issuecomment-1639707646

update multiplus II firmware to latest and check again

V.

[bertvaneyken]

Thanks for the tip!

I just upgraded my GX from 2.93 to 3.02 and the MPII from 5.02 to 5.05

[virtuvas]

please let us know how it's going!

[stuartpittaway]

All - can this issue be closed now?