Stuart Hayhurst
Stuart Hayhurst
Which versions of GNOME has this been tested on? If I remember correctly, GNOME 48 had some big changes, and GNOME 45 - 47 might also have some differences.
Ok, maybe start with https://gjs.guide/extensions/upgrading/gnome-shell-48.html#notifications-per-app-group
> We are safe with Notifications since I implemented single notification only Thanks for checking, I'll give it a quick test on GNOME 45 when I test this PR properly,...
> I got an idea. Since apps can also trigger caffeine why not add a notification to cancel it? Maybe it's a bit too much 😅 Mmm that might make...
> Is 60 seconds instance a good trigger time or shoud I also add a prefs entry for it I reckon we'll get a request to make it configurable pretty...
Hm, just gave this a test. It seems to work, but it's not completely happy: ``` Jun 06 20:18:51 debian-exp gnome-shell[2148]: true Jun 06 20:18:57 debian-exp gnome-shell[2148]: Object Gjs_ui_messageTray_Notification (0x562ebdd01420),...
> what do you think about closing the notification two if app triggers caffeine? What do you mean exactly?
Running it on my system, opening an app as a trigger does nothing while the timer is still running, so no changes needed to the notification there. After the timer...
Feature-wise yes, but we still have a few unresolved threads and I haven't given it thorough testing yet, or testing on GNOME 45.
Got around to testing GNOME 45, it seems that the notification doesn't show: ``` Jun 29 12:59:06 fedora gnome-shell[2258]: true Jun 29 12:59:06 fedora gnome-shell[2258]: JS ERROR: Error: Wrong type...