Dr. Stefan Schimanski

Results 68 issues of Dr. Stefan Schimanski

### Description of your changes Using `GetCache()`'s `IndexField` method will use the passed context for the life-cycle of informers started at that moment. This is usually not what is desired,...

Add progress logs to the applicators: - print creations - print updates/patches with diff - be silent on noop. Based on https://github.com/crossplane/crossplane-runtime/pull/491 Signed-off-by: Dr. Stefan Schimanski

stale

### Description of your changes We use this: ``` return reconcile.Result{Requeue: true}, errors.Wrap(r.client.Status().Update(ctx, managed), errUpdateManagedStatus) ``` This pattern means that the object is immediately (modulo queue delay) reconciled again. We...

stale

### Description of your changes Calling `Update` on a non-unstructured object will potentially lead to data-loss because it is not guaranteed that the object is a complete representation of all...

stale

### Description of your changes This PR does two things: 1. the update applicator is deprecated. The override of the resource version is removed, i.e. the update applicator will correctly...

stale

### Description of your changes Adds a metric `crossplane_resource_drift_seconds` that records the time since the previous reconcile when a resource was found to be out of sync. As we don't...

Edit from @negz: I'd like to drop the `resource.ClientApplicator`. For `*Unstructured` resources we've mostly already replaced it with SSA. For concrete types, I've found a few places where it's been...

bug
exempt-from-stale

### Description of your changes This PR changes the triggering cache for `CompositionRevisions` to `xrCache`, i.e. the informer watching `CompositionRevisions` as long as the XR controller is running. Before this...

Pulled out from https://github.com/crossplane/crossplane/pull/5422. I have: - [x] Read and followed Crossplane's [contribution process]. - [x] Run `make reviewable` to ensure this PR is ready for review. - ~~[ ]...

Got the following empty GitScope toolbox windows: Expected the embedded toolbar and filelist: This used to work. Maybe since last Idea upgrade it is broken? Version 2024.1 (March 28) here.