Dr. Stefan Schimanski

Results 210 comments of Dr. Stefan Schimanski

Actually, this can lose changes that were made before calling the finalizer code, i.e. there is no way around comparing to a fresh object :-/

@phisco with @pedjak's SSA work I expect the applicators basically going away.

The applicators are semantically as broken as before. So yes, it's relevant.

Is this the latest 1.14.x release? https://github.com/crossplane/crossplane/pull/5034 was causing a deadlock on updates to the XRD sometimes. Nvmd. You write 1.14.4 at the bottom.

Wondering, could you attach full debug logs around the time this happens?

@duizabojul https://github.com/crossplane/crossplane-runtime/pull/641 is a potential race when starting the XR controller. Wondering, are you able to test a development version of Crossplane by compiling yourself? Would be great to get...

Yes, vendor in my branch via go.mod of Crossplane.

How can I reproduce this? Could you prepare a minimal example that I can run here locally?

ok, will see whether I can easily reproduce it. Current my assumption is that this even happens without realtime compositions, it's just less surprising.

@negz yes, was expecting that. Matches feedback in https://github.com/crossplane/crossplane/issues/5151. Will take another look when I have time.