Takayuki Sato

Results 65 comments of Takayuki Sato

@phated This cause is that `glob` process multiple readdir only when a given glob string include globstar. https://github.com/isaacs/node-glob/blob/3bfec21dd180ddf4672880176ad33af6296a167e/glob.js#L360

@phated > you aren't allowed to use an object stream with fs writeStream ~~In this Transform, I changed an object to a string.~~ In the above sample code, the `Transform`...

The following is the logs of `isGlobStar` [here](https://github.com/isaacs/node-glob/blob/3bfec21dd180ddf4672880176ad33af6296a167e/glob.js#L358) by the above sample code when a glob string is `'./in/*.txt'`: ``` $ node test.js glob isGlobStar false count = 16 $...

I noticed this issue when I run [the test of `vinyl-fs`](https://github.com/gulpjs/vinyl-fs/blob/df245a40f5dbe37ca620ee71f1a7930cfccb5e42/test/integration.js#L42). This test failed.

https://github.com/isaacs/node-glob/blob/3bfec21dd180ddf4672880176ad33af6296a167e/glob.js#L412-L432 To skip this part lists all files even if a glob string includes no globstar.

The following code which uses `GlobStream` in `readable.js` directly works well. ``` $ cat { ++count; cb(null, f.path + '\n'); }, }); const ws = fs.createWriteStream('./out/out.txt'); pipeline(gs, ts, ws, ()...

@phated I suspect that this issue is due to `ordered-read-streams` from the above results.

This issue is not due to `ordered-read-streams`. The cause is seemed that `glob-stream/readable` uses `highWaterMark` as limit of read count. ``` $ cat max) { this.push(null); break; } this.push(`${cnt}\n`); }...

@phated Is this issue related to https://github.com/gulpjs/gulp-cli/issues/222 ?

@Dan503 There was no problem when I runned #220 with `npm i -D ts-node typescript`. ``` $ git clone https://github.com/Dan503/gulp-cli.git . $ npm i $ node -v v12.18.4 $ npm...