Unneeded items list not working right

[mbeyers]

The un-needed items list appears to be broken. It lists un-needed ship schematics and potentially needed items, but no longer lists items you can safely discard. For instance, I have a Kirk's tribble tray in my inventory, but have a FF Tribble Kirk, so this should be extraneous and should be displayed in the discardable area.

[ussjohnjay]

It's possible that the tool might miss some unneeded items. My guess here is that your Tribble Kirk is not immortalized? That's one of the conditions it looks for currently, though this might be something we can fix.

Also, to be clear, are you saying that the tool also identifies items as unneeded even when you know you need them? That's definitely not the intended behavior and we'll have to look into that one with more urgency.

[MagForceSeven]

I have an example of it identifying items as unneeded when they are. I have two items: 2* Riker's Uniform and 2* Yar's Phaser. It reports those as "used to equip specific crew you already equipped" which is probably true. However, both of those items are used as components for equipment I'm in the process of building for Armus.

[wathou6]

I have noticed this bug for months and ignored the unneeded items tab because of it. I've gone through each item that's been identified as unneeded but half of the choices are inaccurate. It also hasn't identified unneeded items for crew that I have already FF.

[ussjohnjay]

I can confirm that equipment might be listed as unneeded when they're actually needed subcomponents of a higher-level item, as @MagForceSeven pointed out.

@wathou6 The algorithm as written doesn't consider all items, so there's a good chance it will miss out on some equipment that is no longer needed. I think this was generally acceptable because it was better to list too few items than too many. But given the glaring oversight of needed subcomponents, we'll probably have to find a new approach for this tool and we might as well make it more comprehensive in the process.

Thanks for all the feedback. They're much appreciated!