wdio-docker-service icon indicating copy to clipboard operation
wdio-docker-service copied to clipboard

Published 20 hours ago • verified publisher icon stsvilik

Remove `fs-extra` dependency

Open serbanghita opened this issue 6 years ago • 5 comments
trafficstars

@stsvilik I looked over the way we use "fs-extra": "^7.0.0", package and I believe we can get rid of the dependency by having a bunch of local functions in src/utils based on fs native module. Let me know your thoughts on this.

serbanghita avatar Apr 24 '19 09:04 serbanghita

Thats definitely possible - will need to promisify native fs and some refactoring around checking for log files writeability.

stsvilik avatar Apr 24 '19 23:04 stsvilik

Node 16 shipped with fs/promises. This should be easy if it is still something you'd like to do. What version of Node.js do you expect to support? Can we add that in engines.node in package.json?

seanpoulter avatar Feb 22 '24 04:02 seanpoulter

+1 on this change 👍

christian-bromann avatar Feb 22 '24 04:02 christian-bromann

Please not that there is a rewrite on going in #126, so let's coordinate this with the work done by @dons20

christian-bromann avatar Feb 22 '24 04:02 christian-bromann

It also looks like we don't have GitHub workflows configured. Let me know if there are any incremental changes you'd like me to make to help. If I don't hear anything I'll wait for #126.

seanpoulter avatar Feb 22 '24 13:02 seanpoulter