PdfSharpCore icon indicating copy to clipboard operation
PdfSharpCore copied to clipboard

KeyType.NumberTree: Not emplemented.

Open gtmorrell opened this issue 2 years ago • 2 comments

I am needing to create Page Labels for a document. It appears that I need to create a numbertree object to hold an array of dictionaries which correspond to the actual pages and add it to the document.catalog as a PageLabels key. KeysMeta.cs has the following.

                case KeyType.NumberTree:
                    throw new NotImplementedException("KeyType.NumberTree");

Are you going to implement this? If not, is it something I could try and contribute if I can get it resolved?

Thanks for providing PDGSharpCore as open source. It is a great product.

gtmorrell avatar Apr 17 '23 19:04 gtmorrell

Sure, send me a pull-request with your contribution, and I'll merge it. Just, please, if you want me to merge it:

  • don't change the FontResolver
  • do not remove older build targets
  • only do what is necessary to get the number tree working properly, and not 20 more things that do something else in the same commit .
  • when finished, it should also build (without errors) on the older targets.
  • oh, and pull your fork from the latest version. don't just use what you have locally right now, like two weeks after the last pull.

ststeiger avatar Apr 18 '23 10:04 ststeiger

I spent some time looking at the opensource code trying to figure out to implement a numbertree dictionary. In doing so, I realized that I could get the result I needed by creating a PDFLiteral obj with the text string being what a numbertree would produce. I saved it as it to the catalog.items as a /PageLabels Key. It works so I wont need a numbertree at this point. I wish I understood the code better because I would like to contribute. I was just a little overwhelmed. Thank you for your help.

gtmorrell avatar Apr 18 '23 20:04 gtmorrell