PdfSharpCore icon indicating copy to clipboard operation
PdfSharpCore copied to clipboard
verified publisher icon ststeiger

modernize code

Open pamapa opened this issue 3 years ago • 1 comments

  • [ ] String -> string
  • [ ] make build warning free (ev. <TreatWarningsAsErrors>true</TreatWarningsAsErrors>)
  • [ ] make use of nullable feature (needs C# 8) <LangVersion>8.0</LangVersion> <Nullable>enable</Nullable>
  • [ ] StyleCop or something similar

pamapa avatar Jun 02 '22 08:06 pamapa

Please use nullable. We found a silly bug that happened I believe because nullable reference types aren't used. The string we passed was a string? but Visual Studio nor VSCode flagged it when passed to .AddParagraph it seems because PdFSharpCore is still not using nullable reference types.

Image

Stan-Stani avatar Feb 20 '25 16:02 Stan-Stani