emacs_chrome Context menu doesn't work in Chrome

There is nothing happened when I click the context menu item Edit with Emacs in Chrome. After debugging the source code, I found that the tab_port.sender is read-only:

edit-wit-emacs-context-menu-doesnt-work-in-chrome

macOS 10.11.6
Google Chrome 72.0.3626.109 (Official Build) (64-bit)
Edit with Emacs 1.15

Feb 23 '19 15:02 twlz0ne

I wonder if Google have changed the tab port API?

Feb 25 '19 09:02 stsquad

Well I can re-create the problem on Linux with Chrome 72 so I suspect this is a change to the API. Looks like this was last touched in bug #85 but I'll have to do some digging. If you feel upto it you are welcome to have a look yourself.

Feb 25 '19 10:02 stsquad

I think Google made this change just to prevent sender from being modified. So, there is no reason to use it anymore.

Feb 26 '19 08:02 twlz0ne

OK this is weird - it works on my desktop machine...

Mar 16 '19 12:03 stsquad

sigh

Works with Chromium Version 72.0.3626.121 (Developer Build) (64-bit) Fails with Google Chrome Version 73.0.3683.67 (Official Build) beta (64-bit)

Mar 16 '19 12:03 stsquad

@twlz0ne ok I think I've removed the need for tab_port.sender. Can you test the latest master and I'll make a release.

Mar 16 '19 15:03 stsquad

Msg id undefined when I return to the browser after finishing editing:

emacs-chrome-msg-id-undefined

Then there is nothing appears in the textarea.

Mar 16 '19 17:03 twlz0ne

Hmm I'm confused as to what is going wrong then.... and chance you could enable the logging messages and capture them for the whole edit sequence?

Mar 16 '19 23:03 stsquad