emacs_chrome icon indicating copy to clipboard operation
emacs_chrome copied to clipboard

Edit button is added multiple times to text areas

Open netromdk opened this issue 8 years ago • 6 comments

The edit button is added multiple times when a text area is shown/hidden etc. See the attached screenshot:

screen shot 2017-02-20 at 10 30 23

This can happen if you want to comment/edit something and click cancel to hide the text area again, for instance, and should not happen.

Thanks

netromdk avatar Feb 20 '17 09:02 netromdk

BTW it happens for me in JIRA when viewing an issue and clicking "Comment" at the bottom then "Cancel" and "Comment" again. Every repetition adds a new edit button.

netromdk avatar Feb 20 '17 15:02 netromdk

Can you see if this still happens on the https://github.com/stsquad/emacs_chrome/tree/div-background-image-exp branch? It works for me now.

stsquad avatar Jul 04 '17 11:07 stsquad

I confirm that I observe the reported behavior at this time (with the current chrome, editing google spreadsheet). It seems like a new button is added every time I edit the cell editing line.

sam-s avatar Feb 14 '18 20:02 sam-s

Atlassian's forums also have a post regarding this behavior.

krishnoid avatar Jun 12 '18 23:06 krishnoid

@krishnoid I'm afraid that doesn't add much. I've been unable to reproduce the behaviour on the current master branch with either Google Spreadsheets or my local copy of JIRA - although the initial textarea doesn't get it's button due to being created off-screen (see https://github.com/stsquad/emacs_chrome/blob/master/javascript/textareas.js#L180) - this hack maybe outdated now.

Anyway going forward I don't think I can fix this without a proper test case (i.e. a handcrafted page of html/javascript) that reproduces the problem. References to webapps are just too much of a moving target to usefully debug.

stsquad avatar Jun 13 '18 08:06 stsquad

In RoundCube this effect overlays the complete first line of the mail text field:

grafik

I am using melpa as of today and Firefox 67.0.1 under Windows.

Unfortunately I cannot find a publicly available RoundCube installation, but hopefully someone else can also reproduce this. I understand that such a setup is hard to diagnose but on the other hand I think it makes sense to at least document that this problem exists.

laodzu avatar Jun 26 '19 14:06 laodzu