stscijgbot-hstdp
stscijgbot-hstdp
_Comment by [Rick White](https://jira.stsci.edu/secure/ViewProfile.jspa?name=rlw) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=684712#comment-684712):_ The `hla_nexp_flags` function prints a message to the trailer that, indicating that it did in fact run. However, no sources are found to flag....
_Comment by [Rick White](https://jira.stsci.edu/secure/ViewProfile.jspa?name=rlw) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=684716#comment-684716):_ Here is a random idea for what could be causing the problem. The nexp image is created by counting the non-zero pixels in the...
_Comment by [Rick White](https://jira.stsci.edu/secure/ViewProfile.jspa?name=rlw) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=684717#comment-684717):_ Aha! I'm almost sure that is the problem! The drizzled images in the product directory have nan values in blank regions. And [this line](https://github.com/spacetelescope/drizzlepac/blob/66105b9f2cbbd8c038911b0943ddc4433c74ab0b/drizzlepac/haputils/hla_flag_filter.py#L1247C1-L1247C78):...
_Comment by [Rick White](https://jira.stsci.edu/secure/ViewProfile.jspa?name=rlw) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=684774#comment-684774):_ I found one more place in `hla_flag_filters.py` that makes this mistake of using `drz_image != 0` to find blank pixels. In `make_mask_array()` [line 1635](https://github.com/spacetelescope/drizzlepac/blob/66105b9f2cbbd8c038911b0943ddc4433c74ab0b/drizzlepac/haputils/hla_flag_filter.py#L1635)...
_Comment by [Rick White](https://jira.stsci.edu/secure/ViewProfile.jspa?name=rlw) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=701331#comment-701331):_ [Michele De La Pena](https://jira.stsci.edu/secure/ViewProfile.jspa?name=mdelapena) Seems like this particular ticket has been lost in the shuffle. This is pretty important and I think will be...
_Comment by [Michele De La Pena](https://jira.stsci.edu/secure/ViewProfile.jspa?name=mdelapena) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=704938#comment-704938):_ [Rick White](https://jira.stsci.edu/secure/ViewProfile.jspa?name=rlw) I implemented the suggested changes provided by Rick, and I thought they were not resolving the issue. However, this was...
_Comment by [Rick White](https://jira.stsci.edu/secure/ViewProfile.jspa?name=rlw) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=705064#comment-705064):_ [Michele De La Pena](https://jira.stsci.edu/secure/ViewProfile.jspa?name=mdelapena) Thanks for the thorough summary. I agree that it is somewhat strange to have more sources in the filter catalogs...
_Comment by [Michele De La Pena](https://jira.stsci.edu/secure/ViewProfile.jspa?name=mdelapena) on [JIRA](https://jira.stsci.edu/browse/HLA-1213?focusedCommentId=705348#comment-705348):_ Closing this ticket as the code has been merged (PR#⁠1820). A new ticket has been opened as there were very many CRs...
_Comment by [Michele De La Pena](https://jira.stsci.edu/secure/ViewProfile.jspa?name=mdelapena) on [JIRA](https://jira.stsci.edu/browse/HLA-1212?focusedCommentId=685571#comment-685571):_ This is essentially a duplicate ticket to HLA-1162 where there is more discussion. This ticket will be cancelled.
_Comment by [Michele De La Pena](https://jira.stsci.edu/secure/ViewProfile.jspa?name=mdelapena) on [JIRA](https://jira.stsci.edu/browse/HLA-1212?focusedCommentId=685572#comment-685572):_ This is essentially a duplicate ticket to HLA-1162 where there is more discussion. This ticket will be cancelled.