stryker-net icon indicating copy to clipboard operation
stryker-net copied to clipboard

Some inline-disabled mutations look strange in the reports

Open psfinaki opened this issue 2 years ago • 5 comments

Describe the bug So as you can guess, we've updated to Stryker 1.0 and are now making use of the new opportunities so I'm reporting whatever I discover :D That said, the update went quite smoothly, the logs are much cleaner and things work faster for us.

Here's a minor thing. Consider this code:

// Stryker disable once assignment: testing
a += 4;

// Stryker disable once arithmetic: testing
b = a + b;

a += 4;

Stryker respects the directives but for some reason in the first case the report shows the mutation weirdly: image

So it's this particular interference of assignment mutation and disable syntax.

Expected behavior The first mutation shows in the same way as the third.

Desktop (please complete the following information):

  • OS: Windows
  • Type of project: core
  • Framework Version: net5.0
  • Stryker Version: 1.0.1

Additional context Repro: Repro.zip

psfinaki avatar Nov 05 '21 15:11 psfinaki

That is weird 😄

rouke-broersma avatar Nov 05 '21 15:11 rouke-broersma

The whole mutation report is getting an overhaul soon. Let's look into this after we have upgraded to the fancier report.

rouke-broersma avatar Nov 14 '21 22:11 rouke-broersma

Sure!

psfinaki avatar Nov 15 '21 15:11 psfinaki

@psfinaki The updated report is getting released right now! Please let us know what you think and if it's a better experience :)

rouke-broersma avatar Dec 10 '21 22:12 rouke-broersma

Well the report generally looks more beautiful of course but regarding the original issue - it's still there, in a different form now :D image

psfinaki avatar Dec 13 '21 12:12 psfinaki

image It looks like we no longer include the comment into the mutation. Closing the issue

richardwerkman avatar May 26 '23 09:05 richardwerkman