mutation-testing-elements icon indicating copy to clipboard operation
mutation-testing-elements copied to clipboard

JSON Schema: Change type of testsCompleted from number to integer

Open jpgsmits opened this issue 4 years ago • 5 comments

Currently in the JSON schema mutants have a property testsCompleted which tracks how many test cases were executed when trying to kill that mutant. Currently in the schema it is saved as a number, but that should be integer, since you can't execute half a test.

jpgsmits avatar Jul 30 '21 14:07 jpgsmits

Thanks, and good point. Technically a breaking change, but I don't think it should be a major version, agree @hugo-vrijswijk, @richardwerkman @rouke-broersma ?

You want to make the PR, @JSmits-utwente ?

nicojs avatar Jul 30 '21 18:07 nicojs

There is probably no one that relies on it being a number instead of an integer. If someone actually breaks due to this change then I wanna meet them and ask them what the hell they're doing.

rouke-broersma avatar Jul 30 '21 18:07 rouke-broersma

Yeah I agree. I think in metrics-scala it's already an Int

hugo-vrijswijk avatar Jul 30 '21 19:07 hugo-vrijswijk

@JSmits-utwente there might be multiple places where number is used and we actually meant integer

hugo-vrijswijk avatar Jul 30 '21 19:07 hugo-vrijswijk

I'll be sure to check for other odd type choices

jpgsmits avatar Jul 30 '21 21:07 jpgsmits