Handling infe items of type 'uri '

Open dukesook opened this issue 2 years ago • 3 comments

The Box_infe class already contains the std::string m_item_uri_type variable, but no getters/setters for it. The HeifContext::add_generic_metadata() function could be easily extended to handle this capability. Would there be interest if I created a pull request for this functionality?

Jul 21 '23 22:07 dukesook

Implemented in 846f1a84ce87abed724c0e095d43d7ef9357732a and 71cb4396814b1236e5bf09faf17f98b517c410c2. Please check if this meets your requirements.

Nov 01 '23 19:11 farindk

Looks fine for me. @dukesook anything more?

Dec 08 '23 08:12 bradh

@farindk Yes, the heif_item functions look like a great. Is it still possible to merge these into master?

Update: Never mind, you already put these changes in the develop-v1.18.0 branch.

Mar 21 '24 21:03 dukesook