Fix static linking with libde265 on Windows

Open sincos2854 opened this issue 8 months ago • 2 comments

Please read #1506

Apr 20 '25 04:04 sincos2854

I don't think this is a good solution. LIBDE265_STATIC_BUILD is an implementation detail within libde265 and it should not be exposed or used by any client software (including libheif). Furthermore, this patch assumes that libde265 is built statically exactly when libheif is built statically even though these choices are not related in general.

However, I also do not have a better solution. Support for static linking is not in the main scope of the libraries since it usually indicates a license violation.

Apr 20 '25 14:04 farindk

I respect your opinion.

If there are no further discussions, please close the pull request without merging it.

Apr 21 '25 23:04 sincos2854

Transitive usage requirements shouldn't be hardcoded.

Jul 11 '25 18:07 dg0yt

I understand. Thank you very much.

Jul 11 '25 19:07 sincos2854