libheif icon indicating copy to clipboard operation
libheif copied to clipboard

VVdec version in find_package call needs update

Open L4cache opened this issue 1 year ago • 2 comments

VVdec is now 3.0.0, it will be ignored because the target version in CMakeLists.txt is 2.3.0, this can be fixed by simply update the target version, but they also mentioned "changes the API" in the release note, maybe there's more to it.

L4cache avatar Nov 21 '24 08:11 L4cache

I have tested with vvdec 3.0.0. It works without change.

However, I am not sure how to modify the CMakeLists.txt. Fixing it to a specific version does not seem to be the best approach. cmake >=3.19 should be able to accept a version range, but it did not work for me.

farindk avatar Nov 21 '24 16:11 farindk

I think the version check is determined by vvdec's cmake file https://github.com/fraunhoferhhi/vvdec/blob/master/cmake/install/vvdecConfigVersion.cmake.in

L4cache avatar Nov 22 '24 08:11 L4cache