strudel icon indicating copy to clipboard operation
strudel copied to clipboard

fix(Strudel exports): Changed case of Element export to match documen…

Open xolir opened this issue 5 years ago • 2 comments

…tation

BREAKING CHANGE: Usage of element will no longer work

fix #125

xolir avatar Oct 31 '19 11:10 xolir

Will provide appropriate codeshift script

xolir avatar Oct 31 '19 11:10 xolir

Element is a class, but what is exported is a factory - a function generating class instances. Uppercase suggest that you need to instantiate something with new keyword (unless a decorator) which is not a case here.

Such a breaking change doesnt seem to be worth it imho, maybe there are better ways of handling this. Breaking change would require 2.0 release. If documentation is incorrect fix the documentation.

mateuszluczak avatar Nov 01 '19 18:11 mateuszluczak