Mark Struberg

Results 66 comments of Mark Struberg

Hi Seth! I'd rather not depend on BeanUtils. The less dependencies we do have, the better it is imo. The code for picking up the converters is rather trivial. That...

I still wonder if this whole `_transforming` boolean is a bit gone wrong? A.) it is set in a different method than cleared! For no apparent reason. This is not...

hi @dazey3 I took about whole evenings for about a week to dig into the code and all it's constellation I could think of. I think we now understand the...

While talking with @elexx about this issue I had another thought: probably we only need to guard against classes which are touched in `PCClassFileTransformer#needsEnhance`? because once this runs through the...

@gzsombor can you please help us draft an integration test first? I tried to replay your described scenario and I do not see any errors. Here is the code https://github.com/struberg/maven-assembly-plugin/tree/MASSEMBLY-919...

@jeanouii what is not working as you'd expect right now? *edit*: I looked at the unit test in detail and imo the current behaviour is perfectly fine: we have ```...

Did hit the same issue today while upgrading a project. Afaiu the problem is that the RandomizationContext is constructed with the ``CompositeResource``. And from there all the parameterized information is...

This breaks backward compatibility. Got the requirement for backward compatibility with deprecation and pruning phases ditched in JakartaEE? If not we should escalate this question to the council. It might...

BTW, the Jakarta rules explicitly forbid such changes. https://eclipse-ee4j.github.io/jakartaee-platform/CompatibilityRequirements

hi! The difference is that the non-CDI version scans over the events UNTIL it hits START_OBJECT. ``` while (jsonParser.hasNext()) { JsonParser.Event event = jsonParser.next(); while (event == JsonParser.Event.START_OBJECT) { animals.add(animalDeserializer.deserialize(jsonParser,...