loopback4-example-microservices icon indicating copy to clipboard operation
loopback4-example-microservices copied to clipboard

Finish updating this repository

Open shimks opened this issue 6 years ago • 3 comments

There is still some follow up work that needs to be done after #78 (taken from my comment here)

  • follow the instuctions on the README and update either the README or the code to make the repository's features apparent and complete
    • currently, following the steps on README will result in errors
  • leverage lerna to resolve dependencies between services
  • use automatic openapi-v3 schema decorators instead of explicitly defining schemas
    • unless that's the point of this repository. In that case, this repository should be archived until we fully commit to supporting top-down approach.
  • use 'models' and their decorators to define custom types
  • complete switching over repositories to extend from DefaultCrudRepository
  • follow file naming convention advocated over here
  • look into potentially switching from loopback-swagger-connector since LoopBack 4 no longer supports swagger-v2.

There may be a lot being covered in this issue, so it might be appropriate to turn this into an epic.

Description/Steps to reproduce

Link to reproduction sandbox

Expected result

Additional information

shimks avatar Apr 09 '18 21:04 shimks

related to: https://github.com/strongloop/loopback-next/issues/669

dhmlau avatar Apr 10 '18 15:04 dhmlau

I think to make this example more useful we should definitely consider adding lerna

thinusn avatar May 02 '18 14:05 thinusn

@thinusn , would you like to submit a PR? :)

dhmlau avatar May 05 '18 22:05 dhmlau