Ceygen icon indicating copy to clipboard operation
Ceygen copied to clipboard

Upgrading installation to setuptools

Open Dapid opened this issue 8 years ago • 6 comments

This should close #3, and along the way, also #2.

I am having some trouble linking to Eigen in my box, here is the log: https://gist.github.com/Dapid/94cff5f6f3b4124a23da

The problem seems to be lu.

Dapid avatar Sep 17 '15 16:09 Dapid

Travis is using an older Cython that doesn't support explicit relative imports. Upgrading it and retriggering.

Dapid avatar Sep 17 '15 17:09 Dapid

Finally it works! I have bundled a bunch of things in this PR, but it was needed to make it work.

Travis is using Eigen 3.0.5, but the installation fails on Fedora with Eigen 3.2.5, as the log shows. I will go through the release notes and see if there has been any change.

Dapid avatar Sep 17 '15 18:09 Dapid

Thanks for this pul request, I'll look at the commits more closely as soon as I find some time.

One thing to note now, however: would you mind changing the commit messages to be in simple (not continuous) present tense? i.e. "migrate to setuptools" instead of "migrating to setuptools". This is what git developers themselves use, see https://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD

Also, I would prefer if you squash the commit fixups, i.e. hide the sausage-making. (see also https://sethrobertson.github.io/GitBestPractices/#sausage )

strohel avatar Sep 17 '15 21:09 strohel

I have squashed it into three logical commits, that I think will make it easiest to review. All tests pass locally and on Travis.

Dapid avatar Sep 18 '15 01:09 Dapid

Thanks, @Dapid - sorry for being extremely slow to respond, I've been rather busy lately, you know that.. I'll have a look at the latest version when time permits.

strohel avatar Nov 18 '15 10:11 strohel

Don't worry, I understand. Better to get this right.

Dapid avatar Nov 18 '15 10:11 Dapid