Sandro Santilli
Sandro Santilli
It often also happen that people in gitter directly reference issues by short ref like `#345` or `gogits/gogs#4092`. It would be nice to turn them into links as tge context...
I just noticed that the links are sent in their full form to the gitter irc gateway. Evidently it is expected that a "gitter client" would resolve the truncated ones...
Hints from the Gitter side: https://github.com/gitterHQ/realtime-client/issues/21#issuecomment-285242011
I think it is a good idea
It looks like the way to fix this would be to install a listener for "error" on this.socket
I confirm it works by installing an handler, and it can be done from the outside: ``` client = new StatsD(); client.socket.on('error', function(err) { console.log(err); }); ``` I don't know...
I agree it should bubble up. It would also be nice to integrate the documentation in that case. Actually I do see that the current documentation told me about handling...
@tobiasKaminsky it's great to see this coming ! Is your work in a branch for testing ?
Nope, just an idea at the moment. Actually, since this was to solve the cacheability of queries on CDN I was thinking we could obtain the same results with base64...
encodeUriComponent fixes the slash, so no problem about that