netutils-linux icon indicating copy to clipboard operation
netutils-linux copied to clipboard

Add --all option for softirq-top (only) that shows not only network-related metrics

Open strizhechenko opened this issue 7 years ago • 2 comments

  • [ ] fix the tests
    • [ ] utility softirq-top should be runnable at least with --help option
    • [ ] network-top utility should not be affected by changes, at least now. Useless --all given by softirqs module is not a problem to solve now (I'll fix it later somehow).
  • [ ] split --all and normal behavior by checking the options.all in repr()
  • [ ] there's no need to colorize anything except net_rx and net_tx
  • [ ] there's no need to evaluate "hidden" metrics while working without --all option

strizhechenko avatar Jul 29 '17 10:07 strizhechenko

Hi @strizhechenko, working on a patch for this. Can you explain more clearly, what extra information needs to be shown with --all option? Thanks

vipulnayyar avatar Sep 28 '17 10:09 vipulnayyar

Hi!

Look, softirq-top shows data from /proc/softirqs:

# cat /proc/softirqs 
                CPU0       CPU1       CPU2       CPU3       CPU4       CPU5       
      HI:          0          0          0          0          0          0
   TIMER:  175363289   57745326   74077742  876195456   23434777   37222041
  NET_TX:     275135     101780         99     173461          5          2
  NET_RX: 2302171660 2604938496 2358228446 2303193606 2334493439 2029599732
   BLOCK:    7954637          0          0          0          0          0
BLOCK_IOPOLL:          0          0          0          0          0          0
 TASKLET:          9          9          2          0          0          0
   SCHED:   28906952    5492580    5926900   92864400    5282451    5875316
 HRTIMER:     106491      76194      16679      63008      11816       9117
     RCU:  394750147   67060469   86983925  237471224   28579677   41303621

It's currently limited to show only NET_RX and NET_TX softirqs and it should stay default behaviour. So, we need to show all the lines except CPUs.

strizhechenko avatar Sep 28 '17 10:09 strizhechenko