veneur icon indicating copy to clipboard operation
veneur copied to clipboard

Add throttle and fault tags to X-Ray

Open gphat opened this issue 5 years ago • 3 comments

Summary

Adds throttle and fault capability to the X-Ray sink.

Motivation

X-Ray has three different error-like attributes but the conversion from SSFSpan to XRaySegment has nothing to use for these fields.

This adds two new config options that, when the tags are present, sets these fields.

Test plan

Added tests.

gphat avatar Aug 22 '19 21:08 gphat

Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requests

cc @stripe/observability @stripe/observability-stripe

stripe-ci avatar Aug 22 '19 21:08 stripe-ci

(These tests pass locally for me, fwiw. I can't trigger a re-run to test for flakes.)

gphat avatar Aug 24 '19 02:08 gphat

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 06 '20 12:08 CLAassistant