veneur icon indicating copy to clipboard operation
veneur copied to clipboard

Use environment variables when error is strict

Open lahiguera opened this issue 5 years ago • 3 comments

Summary

Fix minor bug in readConfig function when checking the error of unmarshalSemiStrictly.

Motivation

This will allow us to use a configuration that has an unmarshalling strict error, i.e. when the configuration have unknown fields, and the validate-config and validate-config-strict command-line flags are both false.

Test plan

Automated testing.

Rollout/monitoring/revert plan

None

lahiguera avatar Jun 21 '19 23:06 lahiguera

Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requests

cc @stripe/observability @stripe/observability-stripe

stripe-ci avatar Jul 01 '19 16:07 stripe-ci

Handing this over to aditya! (:

asf-stripe avatar Mar 17 '20 16:03 asf-stripe

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 06 '20 12:08 CLAassistant