veneur icon indicating copy to clipboard operation
veneur copied to clipboard

Allow non-integral values for kafka_span_sample_rate_percent

Open ChimeraCoder opened this issue 6 years ago • 3 comments

Summary

Allow non-integer values for the Kafka sample rate. This allows us to sample at rates less than 1% (or rates in between integer values).

Motivation

Test plan

Rollout/monitoring/revert plan

r? @joshu-stripe cc @stripe/observability

ChimeraCoder avatar May 07 '18 14:05 ChimeraCoder

Gerald Rule: Copy Observability on Veneur and Unilog pull requests

cc @stripe/observability cc @stripe/observability-stripe

stripe-ci avatar May 07 '18 14:05 stripe-ci

Joshu is OOO this week

r? @cory-stripe

ChimeraCoder avatar May 07 '18 15:05 ChimeraCoder

👍

From looking at the code it doesn't care of it's a float or not once the signature was fixed. Assuming tests pass looks great!

cory-stripe avatar May 07 '18 15:05 cory-stripe