stripe-react-native icon indicating copy to clipboard operation
stripe-react-native copied to clipboard

Custom font family

Open dqii opened this issue 4 years ago • 9 comments

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like Support custom font families (e.g., those imported with useFonts)

dqii avatar Oct 26 '21 22:10 dqii

Adding context here for anyone else --- https://github.com/stripe/stripe-react-native/pull/247 It seems like custom fonts are only supported as long as they're system fonts.

dqii avatar Oct 30 '21 01:10 dqii

I'm interested in this as well.

edi avatar Oct 31 '21 21:10 edi

Still looking for solutions

binitgurzu avatar Nov 02 '21 15:11 binitgurzu

This is now supported in the Payment Sheet in v0.11.0 🔠

charliecruzan-stripe avatar Jun 01 '22 19:06 charliecruzan-stripe

Reopening- is there desire for this in the components like CardField and CardForm? Or does the Payment Sheet integration suit everyone's needs here?

charliecruzan-stripe avatar Jun 01 '22 19:06 charliecruzan-stripe

Would absolutely love for it to be in CardField and CardForm. We don't use Payment Sheet

dqii avatar Jun 21 '22 18:06 dqii

@dqii can I ask why Payment Sheet doesn't work for your use case? It would help us in making improvements to Payment Sheet :)

charliecruzan-stripe avatar Aug 09 '22 21:08 charliecruzan-stripe

I think purely cosmetic reasons. We wanted more flexibility with the design... we wanted payment method to be provided "inline" for example @charliecruzan-stripe

dqii avatar Aug 11 '22 00:08 dqii

👍 fair enough, that makes sense

charliecruzan-stripe avatar Aug 11 '22 17:08 charliecruzan-stripe

closed in https://github.com/stripe/stripe-react-native/pull/1150

charliecruzan-stripe avatar Oct 20 '22 16:10 charliecruzan-stripe

@charliecruzan-stripe sorry could this be reopened? I think @perqin's diff only added support for Android

dqii avatar Oct 23 '22 19:10 dqii

It seems that custom font is already supported on iOS.

perqin avatar Oct 24 '22 01:10 perqin

@charliecruzan-stripe Is it supported? Last I had heard, this was a blocker to supporting custom fonts on iOS: https://github.com/stripe/stripe-ios/issues/1932

dqii avatar Oct 24 '22 15:10 dqii

If you're looking for custom font control on iOS, I'd recommend either CardField, or the Payment Sheet :) I'm not sure about the timeline for adding this to CardForm so it could take a while

charliecruzan-stripe avatar Oct 24 '22 16:10 charliecruzan-stripe

Oh I use CardField. I didn't realize it was supported there! Thank you. :)

dqii avatar Oct 25 '22 00:10 dqii