stripe-react-native icon indicating copy to clipboard operation
stripe-react-native copied to clipboard

Published 20 hours ago • verified publisher icon stripe

Allow underscores in font names on Android for PaymentSheet appearance

Open goguda opened this issue 1 year ago • 12 comments
trafficstars

Summary

Changed regex expression to allow for underscores in fonts on Android as well, and updated the error to reflect this.

Motivation

See #1636

Testing

  • [x] I tested this manually
  • [ ] I added automated tests

Documentation

Select one:

  • [x] I have added relevant documentation for my changes.
  • [ ] This PR does not result in any developer-facing changes.

goguda avatar Apr 05 '24 20:04 goguda

Hey, this is still an issue in the latest versions and we're having to work around it with patch-package. We would appreciate if this PR could be considered when someone has a chance. Thank you!

goguda avatar May 27 '24 16:05 goguda