stripe-react-native
stripe-react-native copied to clipboard
stripe
Support Fabric components
I'm on RN 0.71.1 and have activated the new architecture and am receiving the message 'CardField' is not fabric compatible yet in place of the actual CardField component.
Is it in the pipeline to make it compatible? This is only an issue in Android, in iOS it works fine.
Yes it's in the pipeline, we'll be migrating all components + the module to turbomodules
@smiley717 sadly the only way to work around this is turn off the new architecture - not great, but it's the only way I could make CardFiled work. Again, this was only an issue in Android for me:
android/gradle.properties:
# Use this property to enable support to the new architecture.
# This will allow you to use TurboModules and the Fabric render in
# your application. You should enable this flag either if you want
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
newArchEnabled=false
# -> this here ^^^^^
@smiley717 You'd have to test it for yourself; my app already existed before the new architecture came with 0.68, so I had no real impact turning it back off.
Your other compile issue may or may not be related to the new architecture, it can be many things, but it's not really the scope of this issue.
Any updates? With the new architecture becoming the default standard, is it still not planned?
New architecture is now default in react native so we should except company like stripe which is tech first payment company to solve these issues sooner and be the leadership in this space, its surprising this issue is open since 8 months with no or little traction.
@charliecruzan-stripe is there any update on when we can expect new version support?
Yes, this is really bad. Probably a hundred libraries in my project and stripe is the holdout breaking new architecture.
Hi all, thank you for sharing all of the feedback here. I agree with you; it's taken us way too long to support the new architecture. Fortunately, I have good news: we have begun our work to start migrating to the new architecture this week and hope to complete it over the next 1-2 months. If anything changes, you can expect to see an update from me here, but I'm optimistic we should be able to complete it by then.
I apologize again for the delay and look forward to getting this shipped for you all soon. Please keep the feedback coming as well; we will do a better job at communicating with you all in GitHub issues going forward.
Hey @sfriedman-stripe , any ETA on the support of new architecture? We're all held back by this.
Hi @arsotech, nothing has changed with the timeline above. Stay tuned!
@sfriedman-stripe thanks. My understanding from your comment above you were looking at 1 - 2 months back in early March. So should we expect it to be shipped in the next 2 - 3 weeks?
@arsotech Yes, we are currently targeting early May. I'll post here if anything changes
As of today the AppStore, including TestFlight, only accepts an iOS 18.x minimum. We’re now in no man's land as we need SDK 52 to build iOS 18 but … Stripe. Any plans to pull the deadline closer? (Asking for a friend)
As of today the AppStore, including TestFlight, only accepts an iOS 18.x minimum
I don't really understand what the problem is here. We have an app that's on the App Store that's on Expo 52 built with iOS 18 that uses the latest version of Stripe React Native. This is only about the new architecture, which is not a requirement to submit an app to the App Store.
As of today the AppStore, including TestFlight, only accepts an iOS 18.x minimum. We’re now in no man's land as we need SDK 52 to build iOS 18 but … Stripe. Any plans to pull the deadline closer? (Asking for a friend)
The deployment target for Expo 52 is iOS 15.1. Your deployment target is not the same as the minimum deployment setting. Apple is requiring the deployment target for your app to be iOS 18, not your minimum deployment.
As of today the AppStore, including TestFlight, only accepts an iOS 18.x minimum. We’re now in no man's land as we need SDK 52 to build iOS 18 but … Stripe. Any plans to pull the deadline closer? (Asking for a friend)
The deployment target for Expo 52 is iOS 15.1. Your deployment target is not the same as the minimum deployment setting. Apple is requiring the deployment target for your app to be iOS 18, not your minimum deployment.
Can I fulfill Apple’s requirement on Expo 51?
Can I fulfill Apple’s requirement on Expo 51?
Let's keep the discussion in this issue focused on the Stripe SDK and the RN architecture. You can refer to the Apple developer forums to learn more about deployment targets.
Hi all, we're excited to share that support for the new architecture has been released today as v0.45.0 (fixed in #1893)! 🎉 Thank you again for your patience.
I will be closing this issue as resolved. If you experience any bugs with this release, please open a new issue as that will help with our tracking. We will not monitor bug reports that come in via this issue after it is closed. We will try to get to new bug reports around the new architecture as soon as possible, as we know new architecture support is important to all of you.
fyi the README still has a warning saying you don't support it 😄 https://github.com/stripe/stripe-react-native?tab=readme-ov-file#stripe-react-native-sdk good work 👏🏼
@sfriedman-stripe why expo doctor say that?
Running "expo doctor" Running 15 checks on your project... 14/15 checks passed. 1 checks failed. Possible issues detected: Use the --verbose flag to see more details about passed checks. ✖ Validate packages against React Native Directory package metadata The following issues were found when validating your dependencies against React Native Directory: Unsupported on New Architecture: @stripe/stripe-react-native
i have 0.45.0 version installed
Hi all, we're excited to share that support for the new architecture has been released today as v0.45.0 (fixed in #1893)! 🎉 Thank you again for your patience.
I will be closing this issue as resolved. If you experience any bugs with this release, please open a new issue as that will help with our tracking. We will not monitor bug reports that come in via this issue after it is closed. We will try to get to new bug reports around the new architecture as soon as possible, as we know new architecture support is important to all of you.
Well done thank you @sfriedman-stripe and the rn stripe team