stripe-react-native icon indicating copy to clipboard operation
stripe-react-native copied to clipboard

Published 20 hours ago • verified publisher icon stripe

Google Pay Button In PaymentSheet not compliant with Google Brand Guidelines

Open P-Russell opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. Our integration is not being approved because the google pay button in our app does not meet Google's brand guidelines

Screen shot of payment sheet using the latest version

GPay-button

New brand guidlines

Screenshot 2022-07-29 at 16 32 57

https://developers.google.com/pay/api/android/guides/brand-guidelines#style

P-Russell avatar Jul 29 '22 14:07 P-Russell

thanks! this is in progress now :)

charliecruzan-stripe avatar Aug 02 '22 18:08 charliecruzan-stripe

@charliecruzan-stripe I noticed also the google pay button (not in the payment sheet ) is not compliant. Do you want me to create a separate ticket for that one or will you fix it along with this one?

remonh87 avatar Aug 08 '22 19:08 remonh87

@charliecruzan-stripe Hello! What is the status of the ticket, is it done or still in progress?

kostiantyn-solianyk avatar Sep 14 '22 13:09 kostiantyn-solianyk

We just fixed this in payment sheet in stripe-android, so pulling in that fix today!

charliecruzan-stripe avatar Sep 14 '22 16:09 charliecruzan-stripe

@charliecruzan-stripe Thanks for the update! What if use GooglePayButton, will it be changed as well according to the new Brand Guidelines? Or it's only for PaymentSheet?

kostiantyn-solianyk avatar Sep 15 '22 06:09 kostiantyn-solianyk

That has also been updated 👍

charliecruzan-stripe avatar Sep 15 '22 14:09 charliecruzan-stripe

Released in 0.19.0

charliecruzan-stripe avatar Sep 16 '22 19:09 charliecruzan-stripe

Hi @charliecruzan-stripe

I'm currently using React Native Expo and the library version

"expo": "46.0.10", "@stripe/stripe-react-native": "0.13.1"

It seems that the Google Pay button hasn't been updated yet. When I created the Google Pay button from import { GooglePayButton } from '@stripe/stripe-react-native'. I still got the old style which is not compliant with Google Brand Guidelines.

Screen Shot 2566-02-14 at 14 11 44

How should I do?

Thank you in advance

tthongprasert avatar Feb 14 '23 07:02 tthongprasert

You'll need to upgrade to v0.19.0 - https://github.com/stripe/stripe-react-native/blob/master/CHANGELOG.md#0190---2022-09-16--expo-sdk-47

charliecruzan-stripe avatar Feb 14 '23 17:02 charliecruzan-stripe

Thanks @charliecruzan-stripe

Does this mean I have to upgrade Expo SDK from 46 to 47 as well?

tthongprasert avatar Feb 14 '23 17:02 tthongprasert

Yes

charliecruzan-stripe avatar Feb 14 '23 17:02 charliecruzan-stripe

google pay button is not displaying in my bottom sheet i add. await Stripe.instance .initPaymentSheet( paymentSheetParameters: SetupPaymentSheetParameters( paymentIntentClientSecret: clientSecret, style: ThemeMode.light, merchantDisplayName: 'Student Bro', googlePay: const PaymentSheetGooglePay( merchantCountryCode: 'GB', currencyCode: 'GBP', testEnv: true ), ), ) this code

srushtiCloudus avatar Aug 16 '23 13:08 srushtiCloudus