stripe-node icon indicating copy to clipboard operation
stripe-node copied to clipboard

Type issues

Open stevez86 opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe.

Some minor issues we identified from the latest API 2024-06-20

  • product.attributes is not typed (https://docs.stripe.com/api/products/object#product_object-attributes)

I'm not getting these fields in my request and they're not typed as optional

  • account.settings.payments.statement_descriptor_prefix (https://docs.stripe.com/api/accounts/object#account_object-settings-payments-statement_descriptor_prefix)
  • account.settings.payments.statement_descriptor_prefix_kana (https://docs.stripe.com/api/accounts/object#account_object-settings-payments-statement_descriptor_prefix_kana)
  • account.settings.payments.statement_descriptor_prefix_kanji (https://docs.stripe.com/api/accounts/object#account_object-settings-payments-statement_descriptor_prefix_kanji)

Describe the solution you'd like

improved types

Describe alternatives you've considered

manually extending Stripe types

Additional context

No response

stevez86 avatar Sep 14 '24 02:09 stevez86

Thanks for reporting @stevez86

https://docs.stripe.com/api/products/object#product_object-attributes is not appearing as a valid link for me. I don't see any attributes on the Product object. Can you share a screen shot of how that section of the docs as it appears to you?

As for the account.settings.payments.statement_descriptor_prefix and other 2 properties, when I dig into the code, I see them on account.settings.card_payments` instead. Will look into why the docs are saying otherwise and get back to you soon

ramya-stripe avatar Sep 17 '24 07:09 ramya-stripe

@stevez86 This is an old issue, but I wanted to follow up. It appears those fields no longer exist in our API. Does this resolve your issue?

mbroshi-stripe avatar Mar 12 '25 13:03 mbroshi-stripe

Closing out, but feel free to re-open w/ more info if it's still an issue!

xavdid-stripe avatar Apr 03 '25 23:04 xavdid-stripe